RE: [PATCH v2 2/4] iio:filter:admv8818: add support for ADMV8818

--
Antoniu Miclăuş

-----Original Message-----
From: kernel test robot <redacted>
Sent: Wednesday, November 24, 2021 5:18 AM
To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org;
robh+dt@kernel.org; linux-iio@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org; Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
Subject: Re: [PATCH v2 2/4] iio:filter:admv8818: add support for ADMV8818

[External]

Hi Antoniu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on v5.16-rc2 next-20211123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://urldefense.com/v3/__https://git-scm.com/docs/git-format-
patch__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmtpaNcqkCI
zWdlzlwyoRyKLHRxkS_1UDWEO$ ]

url:    https://urldefense.com/v3/__https://github.com/0day-
ci/linux/commits/Antoniu-Miclaus/iio-add-filter-subfolder/20211123-
214053__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmtpaNcqk
CIzWdlzlwyoRyKLHRxkS3HtIozj$
base:
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/g
it/jic23/iio.git__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmtp
aNcqkCIzWdlzlwyoRyKLHRxkS8fYcXl7$  togreg
config: x86_64-allyesconfig
(https://urldefense.com/v3/__https://download.01.org/0day-
ci/archive/20211124/202111241151.J9kfWWOf-
lkp@intel.com/config.gz__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQ
OzXhLKmtpaNcqkCIzWdlzlwyoRyKLHRxkS7LldO4I$ )
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://urldefense.com/v3/__https://github.com/0day-
ci/linux/commit/5785226a8e5139d7275a8213a19c4e8479eca28b__;!!A3Ni8CS
0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmtpaNcqkCIzWdlzlwyoRyKLHR
xkSyLuvece$
        git remote add linux-review
https://urldefense.com/v3/__https://github.com/0day-
ci/linux__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmtpaNcqk
CIzWdlzlwyoRyKLHRxkS5pcjrk6$
        git fetch --no-tags linux-review Antoniu-Miclaus/iio-add-filter-
subfolder/20211123-214053
        git checkout 5785226a8e5139d7275a8213a19c4e8479eca28b
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

quoted

drivers/iio/filter/admv8818.c:469:74: error: macro

"IIO_ENUM_AVAILABLE" passed 3 arguments, but takes just 2
     469 |  IIO_ENUM_AVAILABLE("filter_mode", IIO_SHARED_BY_ALL,
&admv8818_mode_enum),
         |                                                                          ^
   In file included from drivers/iio/filter/admv8818.c:14:
   include/linux/iio/iio.h:111: note: macro "IIO_ENUM_AVAILABLE" defined
here
     111 | #define IIO_ENUM_AVAILABLE(_name, _e) \
         |

quoted

quoted

drivers/iio/filter/admv8818.c:469:2: error: 'IIO_ENUM_AVAILABLE'

undeclared here (not in a function)
     469 |  IIO_ENUM_AVAILABLE("filter_mode", IIO_SHARED_BY_ALL,
&admv8818_mode_enum),
         |  ^~~~~~~~~~~~~~~~~~


vim +/IIO_ENUM_AVAILABLE +469 drivers/iio/filter/admv8818.c

   466
   467	static const struct iio_chan_spec_ext_info admv8818_ext_info[] = {
   468		IIO_ENUM("filter_mode", IIO_SHARED_BY_ALL,
&admv8818_mode_enum),
 > 469		IIO_ENUM_AVAILABLE("filter_mode", IIO_SHARED_BY_ALL,
&admv8818_mode_enum),
   470		{ },
   471	};
   472

---
0-DAY CI Kernel Test Service, Intel Corporation
https://urldefense.com/v3/__https://lists.01.org/hyperkitty/list/kbuild-
all@lists.01.org__;!!A3Ni8CS0y2Y!qezv4zARrMS9nlUF2pyY55iNqZQOzXhLKmt
paNcqkCIzWdlzlwyoRyKLHRxkSyoFmbJO$

Similar to ADMV1013, this patch depends on:
https://patchwork.kernel.org/project/linux-iio/patch/20211119085627.6348-1-antoniu.miclaus@analog.com/