Re: [PATCH v3 4/4] arm64: dts: apple: t8103: Add cd321x nodes
flat view
From: Sven Peter <hidden>
Date: 2021-11-23 11:56:49
Also in:
linux-arm-kernel, lkml
On Mon, Nov 22, 2021, at 23:58, Janne Grunau wrote:
quoted hunk ↗ jump to hunk
All M1 Mac devices have 2 SoC connected USB-C ports and use cd321x USB type C port switch and power deliver controllers. I2c bus and adresses configuration are for all devices equal. The iMac (24-inch, 2021) has a configuration with 2 additional USB-C ports (j456) using two addiotional cd321x controllers. Signed-off-by: Janne Grunau <j@jannau.net> --- arch/arm64/boot/dts/apple/t8103-j456.dts | 18 ++++++++++++++++++ arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+)diff --git a/arch/arm64/boot/dts/apple/t8103-j456.dtsb/arch/arm64/boot/dts/apple/t8103-j456.dts index 7267e069355b..c6b8c28455f5 100644--- a/arch/arm64/boot/dts/apple/t8103-j456.dts +++ b/arch/arm64/boot/dts/apple/t8103-j456.dts@@ -21,6 +21,24 @@ aliases { }; }; +&i2c0 { + hpm2: tps6598x@3b {
I know that the tps example in the binding uses tps6598x as the node name but I think that these names are usually more general. Maybe usb-pd@3b instead which is used in arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi and reflects the function of this device. With that fixed: Reviewed-by: Sven Peter <redacted> Thanks, Sven