Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map
From: Marc Zyngier <maz@kernel.org>
Date: 2021-11-23 09:12:08
Also in:
lkml
From: Marc Zyngier <maz@kernel.org>
Date: 2021-11-23 09:12:08
Also in:
lkml
On Tue, 23 Nov 2021 08:40:29 +0000, Sander Vanheule [off-list ref] wrote:
Hi Marc, On Mon, 2021-11-22 at 10:30 +0000, Marc Zyngier wrote:quoted
Since 041284181226 ("of/irq: Allow matching of an interrupt-map local to an interrupt controller"), a handful of interrupt controllers have stopped working correctly. This is due to the DT exposing a non-sensical interrupt-map property, and their drivers relying on the kernel ignoring this property. Since we cannot realistically fix this terrible behaviour, add a quirk for the limited set of devices that have implemented this monster, and document that this is a pretty bad practice. Cc: Rob Herring <robh@kernel.org> Cc: John Crispin <john@phrozen.org> Cc: Biwen Li <redacted> Cc: Chris Brandt <chris.brandt@renesas.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Marc Zyngier <maz@kernel.org>Thanks for the patch. As far as I can tell, this restores the old behaviour from 5.15 for "realtek,rtl-intc" and things work as expected.
Thanks for testing. Let's see what Rob says about this approach (I bet he won't be thrilled...). M. -- Without deviation from the norm, progress is not possible.