Re: [PATCH 2/2] pinctrl: ocelot: Extend support for lan966x
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-11-18 10:51:10
Also in:
linux-gpio, lkml
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-11-18 10:51:10
Also in:
linux-gpio, lkml
On 18/11/2021 09:24:56+0000, Kavyasree.Kotagiri@microchip.com wrote:
quoted
quoted
+ * but it doesn't matter much for now. + * Note: ALT0/ALT1/ALT2 are organized specially for 78 gpio targets + */ + regmap_update_bits(info->map, REG_ALT(0, info, pin->pin), + BIT(p), f << p); + regmap_update_bits(info->map, REG_ALT(1, info, pin->pin), + BIT(p), (f >> 1) << p); + regmap_update_bits(info->map, REG_ALT(2, info, pin->pin), + BIT(p), (f >> 2) << p); +I would have thought the hardware would be fixed because you now have 78 pins and this probably will get worse over time. This is really a poor choice of interface as now you will get two transient states instead of one.Sorry, I couldn't get you. please elaborate what you meant by this comment?
Not mush you can do on your side, this was just a rant. I raised the issue to Allan, hoping that this will get fixed in the next SoCs ;) -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com