Thread (4 messages) 4 messages, 4 authors, 2021-11-18

Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example

From: Gene Chen <hidden>
Date: 2021-11-17 10:53:07
Also in: linux-arm-kernel, linux-leds, linux-mediatek, lkml

cy_huang [off-list ref] 於 2021年11月17日 週三 下午3:22寫道:
quoted hunk ↗ jump to hunk
From: ChiYuan Huang <redacted>

Replace moonlight with indicator in mt6360 example to prevent the below
build error:

Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:385:
Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
Error 1

Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/ (local)
Signed-off-by: ChiYuan Huang <redacted>
---
Hi, Gene:

I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
But you may forget to remove it from the binding example.

Please help to review this change.
---
 Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
index 2353155..b2fe6eb 100644
--- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
@@ -133,7 +133,7 @@ examples:
      };
      led@3 {
        reg = <3>;
-       function = LED_FUNCTION_MOONLIGHT;
+       function = LED_FUNCTION_INDICATOR;
        color = <LED_COLOR_ID_WHITE>;
        led-max-microamp = <150000>;
      };
--
2.7.4
Reviewed-by: Gene Chen <redacted>
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help