Thread (8 messages) 8 messages, 4 authors, 2021-11-12

Re: [PATCH] of/irq: Don't ignore interrupt-controller when interrupt-map failed

From: Marc Zyngier <maz@kernel.org>
Date: 2021-11-12 15:27:03
Also in: lkml
Subsystem: open firmware and flattened device tree, the rest · Maintainers: Rob Herring, Saravana Kannan, Linus Torvalds

On Fri, 12 Nov 2021 14:57:13 +0000,
Rob Herring [off-list ref] wrote:
On Fri, Nov 12, 2021 at 8:37 AM Marc Zyngier [off-list ref] wrote:
quoted
@@ -244,8 +245,14 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)

                        pr_debug(" -> imaplen=%d\n", imaplen);
                }
-               if (!match)
+               if (!match) {
+                       if (intc) {
+                               pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
Let's make this a WARN for !IS_ENABLED(CONFIG_PASEMI). (whatever the
right kconfig symbol is).
I've folded this in.

	M.
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 508fb1717de3..b10f015b2e37 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -247,7 +247,13 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
 		}
 		if (!match) {
 			if (intc) {
-				pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
+				/*
+				 * The PASEMI Nemo is a known offender, so
+				 * let's only warn for anyone else.
+				 */
+				WARN(!IS_ENABLED(CONFIG_PPC_PASEMI),
+				     "%pOF interrupt-map failed, using interrupt-controller\n",
+				     ipar);
 				return 0;
 			}
-- 
Without deviation from the norm, progress is not possible.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help