Thread (21 messages) 21 messages, 7 authors, 2021-11-29

Re: [PATCH 1/2] SPI: Add SPI driver for Sunplus SP7021

From: Andy Shevchenko <hidden>
Date: 2021-11-10 16:47:20
Also in: linux-spi, lkml

On Mon, Nov 1, 2021 at 8:37 PM Mark Brown [off-list ref] wrote:
On Mon, Nov 01, 2021 at 02:18:44PM +0800, LH.Kuo wrote:
quoted
Add SPI driver for Sunplus SP7021.
In general it looks like this needs quite a bit of a refresh for
mainline - a lot of it looks to be a combination of minor, easily
fixable things and stylistic issues which make things hard to follow but
I think there are some more substantial things going on here as well.
Just looked at their UART driver submission with the similar idea in mind.
Asked them to shrink the size 1.5-2x times. I believe this is possible
(and yes, I already saw a new version which is better, but can be
cleaned up more).

Folks, try again for all your drivers for this SoC.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help