RE: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021
From: Wells Lu 呂芳騰 <hidden>
Date: 2021-11-04 05:42:59
Also in:
lkml, netdev
Hi, Thanks a lot for review.
quoted
config NET_VENDOR_SUNPLUS bool "Sunplus devices" default y depends on ARCH_SUNPLUSDoes it actually depend on ARCH_SUNPLUS? What do you make use of?
ARCH_SUNPLUS will be defined for Sunplus family series SoC. Ethernet devices of Sunplus are designed and used for Sunplus SoC. So far, only two SoC of Sunplus have the network device. I'd like to show up the selection only for Sunplus SoC.
Ideally, you want it to also build with COMPILE_TEST, so that the driver gets build by 0-day and all the other build bots.
I am not sure if this is mandatory or not. Should I add COMPILE_TEST as below? depends on ARCH_SUNPLUS | COMPILE_TEST
quoted
---help--- If you have a network (Ethernet) card belonging to this class, say Y here. Note that the answer to this question doesn't directly affect the kernel: saying N will just cause the configurator to skip all the questions about Sunplus cards. If you say Y, you will be asked for your specific card in the following questions. if NET_VENDOR_SUNPLUS config SP7021_EMAC tristate "Sunplus Dual 10M/100M Ethernet (with L2 switch) devices" depends on ETHERNET && SOC_SP7021Does it actually depend on SOC_SP7021 to build? Andrew
Yes, the device is now only for Sunplus SP7021 SoC. Devices in each SoC may have a bit difference because of adding new function or improving something.