Thread (4 messages) 4 messages, 3 authors, 2021-11-02

Re: [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names

From: Rob Herring <robh@kernel.org>
Date: 2021-11-02 22:44:19
Also in: linux-arm-msm, linux-media, lkml

On Tue, Nov 2, 2021 at 3:42 AM Geert Uytterhoeven [off-list ref] wrote:
Hi Rob,

On Mon, Nov 1, 2021 at 10:36 PM Rob Herring [off-list ref] wrote:
quoted
On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote:
quoted
make dt_binding_check:
I'd say it's redundant rather than bogus.
I wrote "bogus", as the "redundant" ones typically give:

                hint: "maxItems" is not needed with an "items" list

And I didn't get that here?
Any schema file with an error shows up twice. First there's all the
specific errors with details. Then there's what you reference which is
all the schemas that we're skipping. If you set DT_SCHEMA_FILES now,
you should only see the second case for other schema files.

So it's probably better to reference the actual error:

Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml:
properties:power-domain-names: {'minItems': 2, 'maxItems': 3, 'items':
[{'const': 'venus'}, {'const': 'vcodec0'}, {'const': 'cx'}]} should
not be valid under {'required': ['maxItems']}
 hint: "maxItems" is not needed with an "items" list
 from schema $id: http://devicetree.org/meta-schemas/items.yaml#
quoted
quoted
    Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
    warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml

Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
 1 file changed, 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help