Re: [PATCH 2/2] ARM: dts: BCM5301X: define RTL8365MB switch on Asus RT-AC88U

On 26/10/2021 11:29, Rafał Miłecki wrote:

On 25.10.2021 23:39, Arınç ÜNAL wrote:

quoted

Define the Realtek RTL8365MB switch without interrupt support on the 
device tree of Asus RT-AC88U.

Signed-off-by: Arınç ÜNAL <redacted>

./scripts/checkpatch.pl doesn't like formatting in your patch:

WARNING: Possible unwrapped commit description (prefer a maximum 75 
chars per line)
#9:
Define the Realtek RTL8365MB switch without interrupt support on the 
device tree of Asus RT-AC88U.


This change introduces new "make ARCH=arm dtbs_check" validation
warnings / errors:

arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch: failed to 
match any schema with compatible: ['realtek,rtl8365mb']
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml:0:0: /switch/mdio: 
failed to match any schema with compatible: ['realtek,smi-mdio']
/home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: 
phy@0: '#phy-cells' is a required property
         From schema: 
/home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml 

/home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: 
phy@1: '#phy-cells' is a required property
         From schema: 
/home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml 

/home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: 
phy@2: '#phy-cells' is a required property
         From schema: 
/home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml 

/home/rmilecki/linux/linux-next/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dt.yaml: 
phy@3: '#phy-cells' is a required property
         From schema: 
/home/rmilecki/.local/lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml 


the first two are caused by realtek-smi.txt not being converted to YAML.
Ignore them.

Later are caused by using phy@ instead of ethernet-phy@ and have to be
fixed.

I'm going to address these in v2, thanks.