Re: [PATCH v9 12/17] ASoC: qdsp6: audioreach: add Kconfig and Makefile

On 25/10/2021 16:49, Mark Brown wrote:

On Wed, Oct 06, 2021 at 12:39:45PM +0100, Srinivas Kandagatla wrote:

quoted

Now that all the code for audioreach and q6apm are in at this point to be
able to compile, start adding Kconfig and Makefile changes.

This doesn't compile with current code for arm64 defconfig:

/mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c: In function 'q6apm_audio_remove':
/mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:703:2: error: too few arguments to function 'snd_soc_tplg_component_remove'
   703 |  snd_soc_tplg_component_remove(component);
       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /mnt/kernel/include/sound/soc-dapm.h:15,
                  from /mnt/kernel/include/sound/soc.h:386,
                  from /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:15:
/mnt/kernel/include/sound/soc-topology.h:191:19: note: declared here
   191 | static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp,
       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This will be with the stub for !SND_SOC_TOPOLOGY, the index argument has
been removed for the actual implementation but not for the stub, the fix
is in the header.

This patch [1] seems to have remove the argument to snd_soc_tplg_component_remove() but not in the stub function.

I can send a patch to fix this

--srini

[1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/include/sound/soc-topology.h?id=a5b8f71c5477f4327c66a085d9714fe298510819