Re: [PATCH 5/6] sdhci: omap: Enable aggressive PM
From: Ulf Hansson <hidden>
Date: 2021-10-12 14:15:32
Also in:
linux-mmc, linux-omap
On Tue, 12 Oct 2021 at 12:38, Tony Lindgren [off-list ref] wrote:
Enable runtime PM for eMMC/SD card devices. Without this, SDIO WLAN devices will not idle.
Just wanted to add some clarification. If the platform is able to idle SDIO card/func devices, you can set MMC_CAP_POWER_OFF_CARD. MMC_CAP_AGGRESSIVE_PM is for eMMC and SD. Perhaps we should consider merging the capabilities flags, as they are in principle indicating the same thing. Anyway, that's a different story. Kind regards Uffe
quoted hunk ↗ jump to hunk
Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/mmc/host/sdhci-omap.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c@@ -1343,6 +1343,9 @@ static int sdhci_omap_probe(struct platform_device *pdev) /* R1B responses is required to properly manage HW busy detection. */ mmc->caps |= MMC_CAP_NEED_RSP_BUSY; + /* Enable runtime PM for eMMC/SD card devices */ + mmc->caps |= MMC_CAP_AGGRESSIVE_PM; + ret = sdhci_setup_host(host); if (ret) goto err_rpm_put; --2.33.0