Re: [PATCH net-next v2 1/9] of: net: move of_net under net/

On Wed, Oct 6, 2021 at 12:12 PM Jakub Kicinski [off-list ref] wrote:

On Wed, 6 Oct 2021 11:58:07 -0500 Rob Herring wrote:

quoted

On Wed, Oct 6, 2021 at 11:34 AM Andrew Lunn [off-list ref] wrote:

quoted

On Wed, Oct 06, 2021 at 11:18:19AM -0500, Rob Herring wrote:

quoted

The OF_NET kconfig should move or disappear too. I imagine you can do just:

It is used in a few places:

Okay, then just move it for now.

I suspect though that most of these can either be dropped or replaced
with just 'OF' dependency.

I have something that builds with allmodconfig :) see below.

Sparc is the arch to try. That's generally we we get tripped up with OF options.

quoted

quoted

net/ethernet/litex/Kconfig:     depends on OF_NET
net/ethernet/amd/Kconfig:       depends on ((OF_NET && OF_ADDRESS) || ACPI || PCI) && HAS_IOMEM

If the driver depends on OF or ACPI, then the dependency should just
be removed because one of those is almost always enabled.

I assumed any OF_* implies OF so just dropping OF_NET.

quoted

quoted

net/ethernet/mscc/Kconfig:      depends on OF_NET
net/ethernet/ezchip/Kconfig:    depends on OF_IRQ && OF_NET
net/ethernet/arc/Kconfig:       depends on OF_IRQ && OF_NET
net/ethernet/arc/Kconfig:       depends on OF_IRQ && OF_NET && REGULATOR

I don't see any OF_IRQ dependency (which would be odd). The OF_NET
dependency is just of_get_phy_mode() from a quick glance and we have a
stub for it.

Hm. Indeed on the OF_IRQ.

net/ethernet/arc/ has irq_of_parse_and_map()

Ah right, but there is a stub for that. The preference is to use
platform_get_irq() instead of irq_of_parse_and_map(), then the OF_IRQ
dependency would really be gone.

but I don't see the need in ezchip, but that seems like a separate matter...