Re: [PATCH v3 11/11] dt-bindings: hwmon: allow specifying channels for tmp421
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-10-02 14:22:23
Also in:
linux-hwmon
On Thu, Sep 30, 2021 at 09:19:49AM +0200, Krzysztof Adamski wrote:
quoted hunk ↗ jump to hunk
Add binding description for the per temperature channel configuration like labels and n-factor. Signed-off-by: Krzysztof Adamski <redacted> --- .../devicetree/bindings/hwmon/ti,tmp421.yaml | 66 +++++++++++++++++++ 1 file changed, 66 insertions(+)diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml index 47040ace4f73..0d4ea2209500 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml@@ -24,12 +24,49 @@ properties: reg: maxItems: 1 + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + required: - compatible - reg additionalProperties: false +patternProperties: + "^input@([0-4])$":
Was there agreement on "input" ? It is a somewhat odd name for a temperature sensor. If that name can be used to distinguish child sensor types, it might make sense to have a well defined name to state that this is a temperature sensor.
+ type: object + description: | + Represents channels of the device and their specific configuration. + + properties: + reg: + description: | + The channel number. 0 is local channel, 1-4 are remote channels
Which of the supported chips has 4 remote channels ?
+ items: + minimum: 0 + maximum: 4 + + label: + description: | + A descriptive name for this channel, like "ambient" or "psu". + + n-factor:
n-factor or "ti,n-factor" ? The unit is chip specific, after all.
+ description: | + The value (two's complement) to be programmed in the channel specific N correction register. + For remote channels only. + items: + minimum: 0 + maximum: 1
Is this the correct value range ? The value range (in integer form) is -128 .. 127 (or 0 .. 255 as unsigned), not 0..1.
quoted hunk ↗ jump to hunk
+ + required: + - reg + + additionalProperties: false + examples: - | i2c {@@ -41,3 +78,32 @@ examples: reg = <0x4c>; }; }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + sensor@4c { + compatible = "ti,tmp422"; + reg = <0x4c>; + #address-cells = <1>; + #size-cells = <0>; + + input@0 { + reg = <0x0>; + n-factor = <0x1>; + label = "local"; + }; + + input@1 { + reg = <0x1>; + n-factor = <0x0>; + label = "somelabel"; + }; + + input@2 { + reg = <0x2>; + status = "disabled"; + }; + }; + };-- 2.31.1