Thread (18 messages) 18 messages, 2 authors, 2021-11-10

Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check compatible oneOf error

From: Rob Herring <robh@kernel.org>
Date: 2021-10-14 20:02:26
Also in: linux-arm-kernel, linux-i2c, linux-serial, lkml

On Wed, Oct 06, 2021 at 04:26:02PM +0300, Abel Vesa wrote:
quoted hunk ↗ jump to hunk
Fix following dtbs_check error:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml:
i2c@5a800000: compatible: 'oneOf' conditional failed, one must be fixed:
        ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
        Additional items are not allowed ('fsl,imx7ulp-lpi2c' was
unexpected)
        'fsl,imx8qxp-lpi2c' was expected
        From schema:
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml

Signed-off-by: Abel Vesa <redacted>
---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
index 29b9447f3b84..acf2d5f45f4e 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
@@ -18,8 +18,11 @@ properties:
       - enum:
           - fsl,imx7ulp-lpi2c
           - fsl,imx8qm-lpi2c
+          - fsl,imx8qxp-lpi2c
Both with and without a fallback should not be valid.

Why are you changing fsl,imx8qxp-lpi2c when the error was for 
fsl,imx8qm-lpi2c?
       - items:
-          - const: fsl,imx8qxp-lpi2c
+          - enum:
+              - fsl,imx8qm-lpi2c
+              - fsl,imx8qxp-lpi2c
           - const: fsl,imx7ulp-lpi2c
 
   reg:
-- 
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help