Re: [PATCH 2/3] dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl compatible
From: Stephen Boyd <hidden>
Date: 2021-10-07 17:59:56
Also in:
alsa-devel, linux-arm-msm, lkml
Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:38)
quoted hunk ↗ jump to hunk
Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. Signed-off-by: Venkata Prasad Potturu <redacted> Signed-off-by: Srinivasa Rao Mandadapu <redacted> --- Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml index e47ebf9..578b283 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml@@ -16,7 +16,9 @@ description: | properties: compatible: - const: qcom,sm8250-lpass-lpi-pinctrl + enum: + - qcom,sc7280-lpass-lpi-pinctrl + - qcom,sm8250-lpass-lpi-pinctrl
I suspect we need to split the binding because the function list needs to change. Can you make a whole new file that's probably largely a copy of this file and/or extract the common bits into a meta schema and include that in both the files? Then the function list can be different and the clock property can be omitted in the sc7280 file.