Re: [PATCH v4 2/7] dt-bindings: memory: lpddr2: Convert to schema
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-10-06 17:32:08
Also in:
linux-tegra, lkml
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-10-06 17:32:08
Also in:
linux-tegra, lkml
06.10.2021 20:23, Krzysztof Kozlowski пишет:
On 06/10/2021 17:44, Dmitry Osipenko wrote:quoted
06.10.2021 18:41, Dmitry Osipenko пишет:quoted
06.10.2021 13:57, Krzysztof Kozlowski пишет:quoted
quoted
+ density: + description: | + Density in megabits of SDRAM chip. Obtained from device datasheet.You need here a type/ref, so uint32.The type is uint32 by default. I can add it, but it's not really necessary.You may grep bindings for 'enum: [' to see that nobody is specifying the type.Just because everyone makes a mistake, is not a proof it should be done like that. Please see example schema and vendor,int-property. AFAIR, only properties defined by schema (directly or by unit suffix, e.g. microvolt) do not need types.
I'm not DT expert, but dt_binding_check says that binding is valid, even with W=1. Meanwhile negative values are wrong. All integers are u32 by default for DTB. Alright, I'll just add the type since it won't hurt anyways.