On 05/10/2021 13:29, Sam Protsenko wrote:

On Wed, 15 Sept 2021 at 11:59, Krzysztof Kozlowski
[off-list ref] wrote:

quoted

quoted

quoted

+             val = ioread32(reg);
+             val |= GATE_MANUAL;
+             val &= ~GATE_ENABLE_HWACG;
+             iowrite32(val, reg);

All other drivers use readl/writel, so how about keeping it consistent?

Ok. Though io* variants looks better to me (API names consistent with
ioremap/iounmap) :)

The io* variants are for PCI I/O and I/O port. Since we know this is
MMIO, all drivers use regular readX/writeX, so let's keep it the same.

Best regards,
Krzysztof