Re: [PATCHv5 0/2] Fix imx53-ppd UART configuration
From: Uwe Kleine-König <hidden>
Date: 2021-10-05 20:18:01
Also in:
linux-serial, lkml
Hello Greg, [adding Rob and devicetree@vger to Cc:] On Fri, May 28, 2021 at 11:03:54AM +0200, Greg Kroah-Hartman wrote:
On Fri, May 28, 2021 at 02:49:52AM +0200, Sebastian Reichel wrote:quoted
On Sat, May 01, 2021 at 08:11:52AM +0200, Greg Kroah-Hartman wrote:quoted
On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:quoted
IMHO PATCHv4 was better, but in the end I don't have strong feelings about this. Btw. I think this patchset is a good demonstration of frustrating upstream kernel development can be considering PATCHv5 is basically the same as PATCHv1. Thanks for making us go in circles :(
I was the one who objected the v1 approach. My frustration is that I wasn't Cc:d in the later iterations of this patch set. And I also liked v4 better :-\
quoted
quoted
quoted
Changes since PATCHv4: * https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/ (local) * use DT property instead of sysfs config option, like the initial patch version did as requested by Greg. Changes since PATCHv3: * https://lore.kernel.org/lkml/1539249903-6316-1-git-send-email-fabien.lahoudere@collabora.com/ (local) * rewrote commit message to provide a lot more details why this is needed * rebased to torvalds/master (5.12-rc1-dontuse), also applies on top of linux-next * use sysfs_emit() instead of sprintf -- Sebastian Fabien Lahoudere (2): serial: imx: Add DMA buffer configuration via DT ARM: dts: imx53-ppd: add dma-info nodes .../bindings/serial/fsl-imx-uart.yaml | 12 +++++++++ arch/arm/boot/dts/imx53-ppd.dts | 2 ++ drivers/tty/serial/imx.c | 25 +++++++++++++------ 3 files changed, 32 insertions(+), 7 deletions(-)This is the friendly semi-automated patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. Right now, the development tree you have sent a patch for is "closed" due to the timing of the merge window. Don't worry, the patch(es) you have sent are not lost, and will be looked at after the merge window is over (after the -rc1 kernel is released by Linus). So thank you for your patience and your patches will be reviewed at this later time, you do not have to do anything further, this is just a short note to let you know the patch status and so you don't worry they didn't make it through. thanks, greg k-h's patch email botAny update on this? :)I'm waiting for the DT maintainers to review the new changes before I can take the driver changes.
I wonder what the DT maintainers said (and where [1]). The patch was applied (db0a196bd8ad1d6bb4b1a9e54f54c09f8dc2cc25) and I think that's wrong (as it was in v1) because fsl,dma-info isn't about hardware description but about software tuning for different use cases. Best regards Uwe [1] neither my mailbox nor lore.kernel.org know about an answer. -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachments
- signature.asc [application/pgp-signature] 488 bytes