Re: [RFC v2 08/11] gpiolib: cdev: Add hardware timestamp clock type
From: Linus Walleij <hidden>
Date: 2021-10-03 21:59:38
Also in:
linux-doc, linux-gpio, linux-tegra, lkml
From: Linus Walleij <hidden>
Date: 2021-10-03 21:59:38
Also in:
linux-doc, linux-gpio, linux-tegra, lkml
On Fri, Oct 1, 2021 at 1:26 AM Dipen Patel [off-list ref] wrote:
This patch adds new clock type for the GPIO controller which can timestamp gpio lines in realtime using hardware means. To expose such functionalities to the userspace, code has been added in this patch where during line create call, it checks for new clock type and if requested, calls hardware timestamp related API from gpiolib.c. During line change event, the HTE subsystem pushes timestamp data through callbacks. Signed-off-by: Dipen Patel <dipenp@nvidia.com> --- Changes in v2: - Added hte_dir and static structure hte_ts_desc. - Added callbacks which get invoked by HTE when new data is available. - Better use of hte_dir and seq from hte_ts_desc. - Modified sw debounce function to accommodate hardware timestamping.
This looks pretty much like I imagined it would, good work! I am a bit busy now and unable to do an in-depth review (brain parse the code and make sure all is sane) but it looks really good, so at least I can say: Acked-by: Linus Walleij <redacted> Yours, Linus Walleij