Thread (6 messages) 6 messages, 4 authors, 2021-10-07

Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants

From: Adam Ford <hidden>
Date: 2021-10-02 12:12:24
Also in: linux-omap, lkml

On Fri, Oct 1, 2021 at 4:59 AM H. Nikolaus Schaller [off-list ref] wrote:

quoted
Am 01.10.2021 um 09:54 schrieb Andreas Kemnade [off-list ref]:

On Sat,  9 Jan 2021 11:01:03 -0600
Adam Ford [off-list ref] wrote:
quoted
Previously, the 1GHz variants were marked as a turbo,
because that variant has reduced thermal operating range.

Now that the thermal throttling is in place, it should be
safe to remove the turbo-mode from the 1GHz variants, because
the CPU will automatically slow if the thermal limit is reached.

Signed-off-by: Adam Ford <redacted>
---
V2:  The orignal patch had the wrong file added. Add the omap36xx.dtsi
hmm, I somehow expected that there is a revert of this thing going
through. But now, the turbo-mode is still missing
tagging by turbo-mode means the OPP is *disabled* by default and
needs to be enabled actively.
quoted
and I understood the
revert is only in Nikolaus' trees.
It is just a revert for the gta04a5 because I think it is the only board
which is affected (maybe it would need SmartReflex in operation to
fine tune the OPPs compared to the generic table). Therefore I have
a patch which adds turbo-mode to the gta04a5.dts
quoted
The 1Ghz mode was working for some
time but does not anymore. Is it just me or do others also have the
same problems?
That would be interesting to know.
What version are you seeing the break?  It's working for me on 5.15.y branch

# cat /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
300000 600000 800000 1000000
# uname -a
Linux buildroot 5.14.9-00260-g70248e7b378b-dirty #1 SMP Sat Oct 2
06:56:02 CDT 2021 armv7l GNU/Linux
#

adam

BR,
NIkolaus
quoted
quoted
diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
index 05fe5ed127b0..20844dbc002e 100644
--- a/arch/arm/boot/dts/omap36xx.dtsi
+++ b/arch/arm/boot/dts/omap36xx.dtsi
@@ -72,7 +72,6 @@ opp1g-1000000000 {
                                      <1375000 1375000 1375000>;
                     /* only on am/dm37x with speed-binned bit set */
                     opp-supported-hw = <0xffffffff 2>;
-                    turbo-mode;
             };
     };
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help