On Tue, Sep 14, 2021 at 06:30:47PM +0300, Abel Vesa wrote:

On 21-09-14 16:11:13, Jacky Bai wrote:

quoted

quoted

Subject: Re: [PATCH v3 1/9] dt-bindings: clock: Add imx8ulp clock support

On 21-09-14 14:52:00, Jacky Bai wrote:

quoted

Add the clock dt-binding file for i.MX8ULP.

For pcc node, it will also be used as a reset controller, so add the
'#reset-cells' property description and add the pcc reset IDs.

Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
 v3 changes:
   - split into two binding file, one for pcc, one for cgc

 v2 changes:
   - removed the redundant clocks & clock-names property

 v1 changes:
   - Move this patch from dts patchset into this patchset
---
 .../bindings/clock/imx8ulp-cgc-clock.yaml     |  43 +++
 .../bindings/clock/imx8ulp-pcc-clock.yaml     |  50 ++++
 include/dt-bindings/clock/imx8ulp-clock.h     | 258

++++++++++++++++++

quoted

 include/dt-bindings/reset/imx8ulp-pcc-reset.h |  59 ++++
 4 files changed, 410 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml
 create mode 100644
Documentation/devicetree/bindings/clock/imx8ulp-pcc-clock.yaml
 create mode 100644 include/dt-bindings/clock/imx8ulp-clock.h
 create mode 100644 include/dt-bindings/reset/imx8ulp-pcc-reset.h

diff --git
a/Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml
b/Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml

I'm not sure but I think the Documentation part is usually done in a separate
patch.

The clk-imx8ulp.c file highly depends on the clock/reset index in this dt-binding patch.

Yeah, I get that, but I was suggesting splitting the Documentation part
and the binding header part into two separate patches. It's up to you.

The header is part of the binding ABI, so it belongs in this patch.

Rob