Re: [PATCH RESEND v2 2/2] ASoC: dt-bindings: rt5682s: add bindings for rt5682s
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2021-09-20 11:29:01
Also in:
alsa-devel
On 07/09/2021 14:05, derek.fang@realtek.com wrote:
quoted hunk
From: Derek Fang <redacted> Realtek ALC5682I-VS codec is a ALC5682I-VD variant which supports I2C only. Signed-off-by: Derek Fang <redacted> --- .../bindings/sound/realtek,rt5682s.yaml | 100 ++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5682s.yamldiff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml new file mode 100644 index 000000000000..fbf23696f1a7 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml@@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/realtek,rt5682s.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek rt5682s codec devicetree bindings + +maintainers: + - Derek Fang <derek.fang@realtek.com> + +description: | + Rt5682s(ALC5682I-VS) is a rt5682i variant which supports I2C only. + +properties: + compatible: + const: realtek,rt5682s + + reg: + maxItems: 1 + description: I2C address of the device. + + interrupts: + description: The CODEC's interrupt output. + + realtek,dmic1-data-pin: + enum: + - 0 # dmic1 data is not used + - 1 # using GPIO2 pin as dmic1 data pin + - 2 # using GPIO5 pin as dmic1 data pin +
+Cc devicetree and Rob, Guys, This is really poor. The patch was never sent to devicetree maintainers and does not build at all! There are several errors here. I fixed few of them: https://lore.kernel.org/lkml/20210920112106.140918-1-krzysztof.kozlowski@canonical.com/ (local) but still you need to fix missing description for vendor fields. Derek, Your duty is to use get_maintainers.pl script to Cc all relevant maintainers and mailing lists. Second duty is to test it. This was not tested. Best regards, Krzysztof