Thread (54 messages) 54 messages, 5 authors, 2021-09-08

Re: [PATCH v5 15/21] ASoC: qdsp6: audioreach: add q6apm support

flat view

From: Pierre-Louis Bossart <hidden>
Date: 2021-09-07 16:09:04
Also in: alsa-devel

quoted
quoted
+    graph->graph = audioreach_alloc_graph_pkt(apm, &info->sg_list,
graph_id);
+    if (IS_ERR(graph->graph)) {
+        kfree(graph);
+        return ERR_PTR(-ENOMEM);
+    }
+
+    spin_lock(&apm->lock);
+    idr_alloc(&apm->graph_idr, graph, graph_id,
+          graph_id + 1, GFP_ATOMIC);
does this need to be ATOMIC?
We are inside spinlock.
but this is not used in an interrupt handler or anything that isn't in a
process context, is it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help