Thread (88 messages) 88 messages, 4 authors, 2021-09-05

Re: [PATCH 03/40] dt-bindings: touchscreen: ti,am3359-tsc: New yaml description

From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2021-09-01 07:42:56
Also in: linux-clk, linux-iio, linux-input, linux-omap

Hi Rob,
quoted
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>  
I prefer that MFDs have just 1 complete example in the MFD schema. 
Just to be on the same line, you ask me to drop the all the lines from

	tscadc:

up to

	dma-names = ...;

and keep only the tsc node, right?

I guess I should do the same in the ADC binding then.
quoted
+
+    tscadc: tscadc@0 {  
Drop unused labels.
quoted
+        compatible = "ti,am3359-tscadc";
+        reg = <0x0 0x1000>;
+        interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&adc_tsc_fck>;
+        clock-names = "fck";
+        status = "disabled";  
status, again.
quoted
+        dmas = <&edma 53 0>, <&edma 57 0>;
+        dma-names = "fifo0", "fifo1";
+
+        tsc {
+            compatible = "ti,am3359-tsc";
+            ti,wires = <4>;
+            ti,x-plate-resistance = <200>;
+            ti,coordinate-readouts = <5>;
+            ti,wire-config = <0x00 0x11 0x22 0x33>;
+            ti,charge-delay = <0x400>;
+        };
+    };
-- 
2.27.0

  
Thanks,
Miquèl
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help