Thread (17 messages) 17 messages, 4 authors, 2021-10-05

Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

From: Stephen Boyd <hidden>
Date: 2021-09-30 17:58:36
Also in: dri-devel, linux-arm-msm, lkml

Quoting mkrishn@codeaurora.org (2021-09-30 04:56:59)
On 2021-08-19 01:27, Stephen Boyd wrote:
quoted
Quoting Krishna Manikandan (2021-08-18 03:27:02)
quoted
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 53a21d0..fd7ff1c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
+
+                       status = "disabled";
+
+                       mdp: mdp@ae01000 {
display-controller@ae01000
Stephen,
    In the current driver code, there is a substring comparison for "mdp"
in device node name as part of probe sequence. If "mdp" is not present
in the node name, it will
    return an error resulting in probe failure. Can we continue using mdp
as nodename instead of display controller?
Can we fix the driver to not look for node names and look for compatible
strings instead? It took me a minute to find compare_name_mdp() in
drivers/gpu/drm/msm/msm_drv.c to understand what you're talking about.
Perhaps looking for qcom,mdp5 in there will be sufficient instead of
looking at the node name.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help