Re: [PATCH v5 10/14] arm64: apple: Add pinctrl nodes

From
Marc Zyngier <maz@kernel.org>
Date
2021-09-30 08:04:11
Also in
linux-pci, lkml
Reply to
Linus Walleij, 2021-09-29
On Wed, 29 Sep 2021 20:05:42 +0100,
Linus Walleij [off-list ref] wrote:
On Wed, Sep 29, 2021 at 6:56 PM Marc Zyngier [off-list ref] wrote:
quoted
From: Mark Kettenis <redacted>

Add pinctrl nodes corresponding to the gpio,t8101 nodes in the
Apple device tree for the Mac mini (M1, 2020).

Clock references are left out at the moment and will be added once
the appropriate bindings have been settled upon.

Signed-off-by: Mark Kettenis <redacted>
Reviewed-by: Linus Walleij <redacted>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210520171310.772-3-mark.kettenis@xs4all.nl (local)
(...)
quoted
+               pinctrl_ap: pinctrl@23c100000 {
+                       compatible = "apple,t8103-pinctrl", "apple,pinctrl";
+                       reg = <0x2 0x3c100000 0x0 0x100000>;
+
+                       gpio-controller;
+                       #gpio-cells = <2>;
+                       gpio-ranges = <&pinctrl_ap 0 0 212>;
In other discussions it turns out that the driver is abusing these gpio-ranges
to find out how many pins are in each pinctrl instance. This is not the
idea with gpio-ranges, these can be multiple and map different sets,
so we need something like

apple,npins = <212>;
(+ bindings)

or so...
Is it the driver that needs updating? Or the binding? I don't really
care about the former, but the latter is more disruptive as it has
impacts over both u-boot and at least OpenBSD.

How is that solved on other pinctrl blocks? I can't see anyone having
a similar a similar property.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.
Thread (31 messages) 31 messages, 6 authors, last reply 2021-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help