Thread (6 messages) 6 messages, 3 authors, 2021-09-23

Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-09-23 22:12:36
Also in: linux-arm-kernel, linux-iio, lkml

Hi Cai,

On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing [off-list ref] wrote:
+error_iio_device_register:
+       clk_disable_unprepare(adc->ipg_clk);
+error_adc_ipg_clk_enable:
+       clk_disable_unprepare(adc->clk);
+error_adc_clk_enable:
+       regulator_disable(adc->vref);
Please rename these labels to indicate the action that will be performed.

Something like this:

error_ipg_clk_disable:
       clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
       clk_disable_unprepare(adc->clk);
error_regulator_disable:
       regulator_disable(adc->vref);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help