[RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration · Krzysztof Kozlowski <hidden> · 2021-09-22
[RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() · Krzysztof Kozlowski <hidden> · 2021-09-22
Re: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() · Christophe Leroy <hidden> · 2021-09-22
Re: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() · Krzysztof Kozlowski <hidden> · 2021-09-22
Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration · Christophe Leroy <hidden> · 2021-09-22
Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration · Krzysztof Kozlowski <hidden> · 2021-09-22

Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

From: Krzysztof Kozlowski <hidden>
Date: 2021-09-22 14:10:30
Also in: linuxppc-dev, lkml

On 22/09/2021 15:52, Christophe Leroy wrote:


Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit :

quoted

g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c,
so it should have a declaration to fix W=1 warning:

   arch/powerpc/platforms/powermac/feature.c:1533:6:
     error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes]


While you are at it, can you clean it up completely, that is remove the 
declaration in arch/powerpc/platforms/powermac/smp.c ?

Sure, I'll send a v2. Thanks for pointing this out.


Best regards,
Krzysztof

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help