Re: [PATCH 4/4] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp
From: Stephen Boyd <hidden>
Date: 2021-09-21 01:40:03
Also in:
linux-arm-msm, lkml
Quoting Satya Priya (2021-09-17 03:45:38)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 52638e2..3b3af49 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi@@ -207,6 +207,97 @@ }; }; +&i2c1 { + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + pm8008_chip: pm8008@8 { + compatible = "qcom,pm8008"; + reg = <0x8>; + #address-cells = <1>; + #size-cells = <0>; + + pinctrl-names = "default"; + pinctrl-0 = <&pm8008_active>; + }; + + pm8008_ldo: pm8008@9 {
[...]
+
+ pm8008_l7: regulator@4600 {
+ reg = <0x4600>;
+ regulator-name = "pm8008_l7";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3544000>;
+ qcom,min-dropout-voltage = <96000>;Is this headroom? Is it actually configurable or is it merely a property of the hardware? If it's the latter then it should be in the driver and not in the DTS.
quoted hunk ↗ jump to hunk
+ }; + }; + }; +}; + &qfprom { vcc-supply = <&vreg_l1c_1p8>; };@@ -313,6 +404,18 @@ /* PINCTRL - additions to nodes defined in sc7280.dtsi */ +&pm8350c_gpios { + pm8008_reset {
Is this a pinctrl node?
+ pm8008_active: pm8008_active {Please use dashes in node names wherever an underscore goes.
+ pins = "gpio4"; + function = "normal"; + bias-disable; + output-high; + power-source = <0>; + }; + }; +};