Thread (8 messages) 8 messages, 3 authors, 2021-09-20

Re: [PATCH v3 7/9] dt-bindings: arm: fsl: clean-up all toradex boards/modules

From: Marcel Ziswiler <hidden>
Date: 2021-09-20 14:53:26
Also in: linux-arm-kernel, lkml

On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote:
On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote:
quoted
From: Marcel Ziswiler <redacted>

Simplify and unify the distinction between modules and carrier boards.

Signed-off-by: Marcel Ziswiler <redacted>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

Changes in v3:
- Add Fabio's reviewed-by. Thanks!
- Add Rob's ack. Thanks!

Changes in v2:
- New patch cleaning-up dt-bindings documentation.

 .../devicetree/bindings/arm/fsl.yaml          | 79 ++++++++++---------
 1 file changed, 41 insertions(+), 38 deletions(-)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters)
(line-length)
./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters)
(line-length)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1529833

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade
After submitting the fixed V4 I went back to my V3 branch and now it suddenly shows it properly. I guess,
something got stuck somewhere (;-p).

⬢[zim@toolbox linux-next.git]$ make O=../../Builds/linux-arm-next-imx_v6_v7/ DT_CHECKER_FLAGS=-m
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml dt_binding_check
make[1]: Entering directory '/var/home/zim/Builds/linux-arm-next-imx_v6_v7'
  LINT    Documentation/devicetree/bindings
/var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too
long (113 > 110 characters) (line-length)
/var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:613:111: [warning] line too
long (113 > 110 characters) (line-length)
/var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:620:111: [warning] line too
long (113 > 110 characters) (line-length)
Please check and re-submit.
Anyway, the V4 has this all fixed. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help