[v3 05/24] clk: mediatek: Fix resource leak in mtk_clk_simple_probe
flat view
STALE1866d
LANDED: 1 (1M)
From: Chun-Jie Chen <hidden>
Date: 2021-09-14 02:17:11
Also in:
linux-arm-kernel, linux-clk, linux-mediatek, lkml
Subsystem:
common clk framework, the rest · Maintainers:
Stephen Boyd, Brian Masney, Jerome Brunet, Linus Torvalds
Revision v3 of 3 in this series; 1 review trailer; landed in mainline as 6203815bf97e on 2021-09-14.
Revisions (3)
- v1 [diff vs current]
- v2 [diff vs current]
- v3 current
Release clock data when clock driver probe fail to fix possible resource leak. Signed-off-by: Chun-Jie Chen <redacted> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/clk/mediatek/clk-mtk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c
index c3d385c0cfcb..74890759e98c 100644
--- a/drivers/clk/mediatek/clk-mtk.c
+++ b/drivers/clk/mediatek/clk-mtk.c@@ -314,7 +314,15 @@ int mtk_clk_simple_probe(struct platform_device *pdev) r = mtk_clk_register_gates(node, mcd->clks, mcd->num_clks, clk_data); if (r) - return r; + goto free_data; - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); + if (r) + goto free_data; + + return r; + +free_data: + mtk_free_clk_data(clk_data); + return r; }
--
2.18.0