Re: [PATCH v3 02/10] of/irq: Allow matching of an interrupt-map local to an interrupt controller

From
Rob Herring <robh+dt@kernel.org>
Date
2021-09-13 21:13:44
Also in
linux-pci, lkml
Reply to
Marc Zyngier, 2021-09-13
On Mon, Sep 13, 2021 at 1:26 PM Marc Zyngier [off-list ref] wrote:
of_irq_parse_raw() has a baked assumption that if a node has an
interrupt-controller property, it cannot possibly also have an
interrupt-map property (the latter being ignored).

This seems to be an odd behaviour, and there are no reason why
s/are/is/
we should avoid supporting this use case. This is specially
useful when a PCI root port acts as an interrupt controller for
PCI endpoints, such as this:

pcie0: pcie@690000000 {
        [...]
        port00: pci@0,0 {
                device_type = "pci";
                [...]
                #address-cells = <3>;

                interrupt-controller;
                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 7>;
                interrupt-map = <0 0 0 1 &port00 0 0 0 0>,
                                <0 0 0 2 &port00 0 0 0 1>,
                                <0 0 0 3 &port00 0 0 0 2>,
                                <0 0 0 4 &port00 0 0 0 3>;
        };
};

Handle it by detecting that we have an interrupt-map early in the
parsing, and special case the situation where the phandle in the
interrupt map refers to the current node (which is the interesting
case here).

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 drivers/of/irq.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
Thread (27 messages) 27 messages, 6 authors, last reply 2021-09-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help