Re: [PATCH V2 00/13] soc: imx: gpcv2: support i.MX8MM
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Date: 2021-09-03 12:26:50
Also in:
linux-arm-kernel, linux-media, lkml
Le 09/08/2021 à 10:15, Lucas Stach a écrit :
Hi Ezequiel, Am Mittwoch, dem 04.08.2021 um 11:30 -0300 schrieb Ezequiel Garcia:quoted
Hi Peng, Lucas, On Wed, 5 May 2021 at 21:32, Peng Fan (OSS) [off-list ref] wrote:quoted
From: Peng Fan <peng.fan@nxp.com> V2: - Add R-b/A-b tag - Merge V1 patch 13 to V2 patch 6 - Drop V1 patch 15 - Merge V1 patch 16 to V2 patch 5 and add comments in patch 5 to explain details - Add explaination in patch 8 for "why the resets are not defined" This patchset is a pick up Lucas's gpcv2 work for i.MX8MM and several minor changes from me to make it could work with i.MX BLK-CTL driver. Thanks for Lucas's work and suggestion, Frieder Schrempf for collecting all the patches, Jacky Bai on help debug issues. Lucas Stach (12): soc: imx: gpcv2: move to more ideomatic error handling in probe soc: imx: gpcv2: move domain mapping to domain driver probe soc: imx: gpcv2: switch to clk_bulk_* API soc: imx: gpcv2: split power up and power down sequence control soc: imx: gpcv2: wait for ADB400 handshake soc: imx: gpcv2: add runtime PM support for power-domains soc: imx: gpcv2: allow domains without power-sequence control dt-bindings: imx: gpcv2: add support for optional resets soc: imx: gpcv2: add support for optional resets dt-bindings: power: add defines for i.MX8MM power domains soc: imx: gpcv2: add support for i.MX8MM power domains soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power domainsIt's nice to see this finally moving forward! As you know, Hantro G2 support for i.MX8MQ (and i.MX8MP, i.MX8MM) is currently blocked, as you have requested: https://lore.kernel.org/driverdev-devel/5aa5700b862234895a7a6eb251ca3c80fdc1a6d3.camel@collabora.com/ (local) So, I think we really need to include i.MX8MP and i.MX8MQ on this series. It's been quite a while and we really need to have that. To be honest, I fear that if we merge this series as-is, MX8MP and MX8MP support will fall in the oblivion, and Hantro G2 VPU will remain unusable. We are planning to submit Hantro G2 VP9 support soon, and we've been testing on various platforms, but it will also be blocked by lack of power-domains. In the future, please Cc the linux-media mailing list, as well as Benjamin, Andrzej and myself, so we can follow this.Please take a look at [1], which is the current state of this work. I intend to add both i.MX8MQ and i.MX8MP support to the series now, as it seems that there have been no big objections to my approach over the last 2 weeks, where I was on vacation. ;)
Hi Lucas, I have tried to implement the block control driver for imx8mq. I didn't manage to get it working. My implementation is here: https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/tree/IMX8MQ_BLK_CTRL While you have the same in IMX8MM do you have also made changes in Hantro driver ? If it is that can you share these changes ? I have include mine in the above branch. Regards, Benjamin
Regards, Lucas [1] https://lore.kernel.org/linux-arm-kernel/20210716232916.3572966-14-l.stach@pengutronix.de/T/#m43cbf6b8615b2a37ff2abb0346e7e7f6594976d1 (local)