Re: [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes
From: Stephen Boyd <hidden>
Date: 2021-09-01 05:04:44
Also in:
linux-arm-msm, lkml
From: Stephen Boyd <hidden>
Date: 2021-09-01 05:04:44
Also in:
linux-arm-msm, lkml
Quoting rajpat@codeaurora.org (2021-08-31 08:28:51)
On 2021-08-26 23:41, Stephen Boyd wrote:quoted
Quoting Rajesh Patil (2021-08-26 06:15:30)quoted
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsib/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 7c106c0..65126a7 100644--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi@@ -225,6 +225,10 @@ status = "okay"; }; +&qupv3_id_1 { + status = "okay"; +}; +Why enable this here but not any of the i2c/spi/uart devices that are a child? Can this hunk be split off to a different patch?Currently there is no usecase on qup1 and hence not enabled. Regarding splitting this, I did not get the exact reason why we need to split. This patch adds all the qup wrapper1 nodes and we are enabling it in board file.
I'm happy to see this part dropped from the patch. If nothing is enabled that's a child of the qup then enabling it serves no purpose.