RE: [PATCH v11] dt-bindings: ufs: Add bindings for Samsung ufs host

Hi Rob,

Could you kindly review this?

Best Regards,
Chanho Park

-----Original Message-----
From: Alim Akhtar <redacted>
Sent: Friday, August 20, 2021 1:19 AM
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: open list <redacted>; linux-arm-
kernel@lists.infradead.org; robh+dt [off-list ref]; Krzysztof
Kozlowski [off-list ref]; linux-samsung-
soc@vger.kernel.org; Martin K. Petersen [off-list ref]
Subject: Re: [PATCH v11] dt-bindings: ufs: Add bindings for Samsung ufs
host

Hi Rob
Can you pick up this patch via your tree? or you want Martin to pick it up?

On Sat, Aug 14, 2021 at 10:25 PM Alim Akhtar [off-list ref] wrote:

quoted

Ping!!

On Wed, Aug 4, 2021 at 9:01 AM Alim Akhtar [off-list ref]

wrote:

quoted

quoted

This patch adds DT bindings for Samsung ufs hci

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
Changes since v10
* Rebased on v5.14-rc2
* removed Rob Herring earlier Reviewed-by tag

This patch was part of exynos ufs driver series, somehow this got
missed to applied on the tree, sending again as a new patch v11,
removing Rob's earlier Reviewed-by tag.

 .../bindings/ufs/samsung,exynos-ufs.yaml      | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml

diff --git
a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
new file mode 100644
index 000000000000..38193975c9f1

--- /dev/null
+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml

@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
+---
+$id:
+https://protect2.fireeye.com/v1/url?k=87b3fb9f-d828c295-87b270d0-0c
+c47a31384a-2d1da91e6c1569ad&q=1&e=3ebd4447-410b-4abb-b6e0-88b0310be
+d3f&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fufs%2Fsamsung%2Cexyno
+s-ufs.yaml%23
+$schema:
+https://protect2.fireeye.com/v1/url?k=15695c41-4af2654b-1568d70e-0c
+c47a31384a-797602fbe8e5ab79&q=1&e=3ebd4447-410b-4abb-b6e0-88b0310be
+d3f&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
+
+title: Samsung SoC series UFS host controller Device Tree Bindings
+
+maintainers:
+  - Alim Akhtar <alim.akhtar@samsung.com>
+
+description: |
+  Each Samsung UFS host controller instance should have its own node.
+  This binding define Samsung specific binding other then what is
+used
+  in the common ufshcd bindings
+  [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+
+properties:
+
+  compatible:
+    enum:
+      - samsung,exynos7-ufs
+
+  reg:
+    items:
+     - description: HCI register
+     - description: vendor specific register
+     - description: unipro register
+     - description: UFS protector register
+
+  reg-names:
+    items:
+      - const: hci
+      - const: vs_hci
+      - const: unipro
+      - const: ufsp
+
+  clocks:
+    items:
+      - description: ufs link core clock
+      - description: unipro main clock
+
+  clock-names:
+    items:
+      - const: core_clk
+      - const: sclk_unipro_main
+
+  interrupts:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: ufs-phy
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phys
+  - phy-names
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/exynos7-clk.h>
+
+    ufs: ufs@15570000 {
+       compatible = "samsung,exynos7-ufs";
+       reg = <0x15570000 0x100>,
+             <0x15570100 0x100>,
+             <0x15571000 0x200>,
+             <0x15572000 0x300>;
+       reg-names = "hci", "vs_hci", "unipro", "ufsp";
+       interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+       clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
+                <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
+       clock-names = "core_clk", "sclk_unipro_main";
+       pinctrl-names = "default";
+       pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
+       phys = <&ufs_phy>;
+       phy-names = "ufs-phy";
+    };
+...

base-commit: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c
--
2.17.1

--
Regards,
Alim

--
Regards,
Alim