[PATCH] dt-bindings: display/bridge: document enable-panel for, sn65dsi83

Subsystems: drm drivers, drm drivers and misc gpu patches, drm drivers for bridge chips, open firmware and flattened device tree bindings, the rest

STALE1876d

3 messages, 2 authors, 2021-08-26 · open the first message on its own page

[PATCH] dt-bindings: display/bridge: document enable-panel for, sn65dsi83

From: Daniels Umanovskis <hidden>
Date: 2021-08-25 10:21:51

The driver supports an optional GPIO specifier for a pin that
enables the connected panel, but it's not documented in dt-bindings

Signed-off-by: Daniels Umanovskis <redacted>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml      | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index d101233ae17..1aca6c1a8e0 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -32,6 +32,10 @@ properties:
     maxItems: 1
     description: GPIO specifier for bridge_en pin (active high).

+  enable-panel-gpios:
+    maxItems: 1
+    description: GPIO specifier for the panel's enable pin (active high).
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports

-- 
2.30.2

Re: [PATCH] dt-bindings: display/bridge: document enable-panel for, sn65dsi83

From: Rob Herring <robh@kernel.org>
Date: 2021-08-25 16:26:16

On Wed, Aug 25, 2021 at 12:21:44PM +0200, Daniels Umanovskis wrote:
The driver supports an optional GPIO specifier for a pin that
enables the connected panel, but it's not documented in dt-bindings
The subject looks mangled with the ',' and 'ti' is missing.

(There's a common issue with a space getting inserted after a comma on 
some maillists like dridevel, but the DT list doesn't have that issue.)
quoted hunk
Signed-off-by: Daniels Umanovskis <redacted>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml      | 4 ++++
 1 file changed, 4 insertions(+)

diff --git
a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index d101233ae17..1aca6c1a8e0 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -32,6 +32,10 @@ properties:
     maxItems: 1
     description: GPIO specifier for bridge_en pin (active high).

+  enable-panel-gpios:
+    maxItems: 1
+    description: GPIO specifier for the panel's enable pin (active high).
+
There's already the common 'enable-gpios' property. Use that.
   ports:
     $ref: /schemas/graph.yaml#/properties/ports

-- 
2.30.2

Re: [PATCH] dt-bindings: display/bridge: document enable-panel for, sn65dsi83

From: Daniels Umanovskis <hidden>
Date: 2021-08-26 11:12:11

On 8/25/21 6:26 PM, Rob Herring wrote:
quoted
Signed-off-by: Daniels Umanovskis <redacted>
---
  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml      | 4 ++++
  1 file changed, 4 insertions(+)

diff --git
a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index d101233ae17..1aca6c1a8e0 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -32,6 +32,10 @@ properties:
      maxItems: 1
      description: GPIO specifier for bridge_en pin (active high).

+  enable-panel-gpios:
+    maxItems: 1
+    description: GPIO specifier for the panel's enable pin (active high).
+
There's already the common 'enable-gpios' property. Use that.
Could you clarify if you're suggesting a change to the driver instead?
The driver uses enable-gpios to specify one GPIO (the bridge's EN pin),
and optionally enable-panel-gpios for the panel. The patch was intended
to document that behavior.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help