Thread (16 messages) 16 messages, 5 authors, 2021-08-13

Re: [PATCH v2 4/6] usb: dwc3: reference clock period configuration

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-04 14:14:12
Also in: linux-arm-kernel, linux-arm-msm, linux-phy, linux-usb

Hi,

Baruch Siach [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -1371,6 +1398,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
 				    &dwc->hsphy_interface);
 	device_property_read_u32(dev, "snps,quirk-frame-length-adjustment",
 				 &dwc->fladj);
+	device_property_read_u32(dev, "snps,ref-clock-period",
+				 &dwc->ref_clk_per);
I wonder if it would make more sense to pass an actual clock reference
here. If valid, then reconfigure the period to the value returned by
clk_get_rate(). It would avoid yet another DT binding. If we make the
clock optional, then we won't affect any other platforms. The clock
itself could be a regular fixed clock node.

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help