Thread (14 messages) 14 messages, 4 authors, 2021-08-06

Re: [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name

From: Marc Zyngier <maz@kernel.org>
Date: 2021-08-02 10:25:27
Also in: linux-arm-kernel

On 2021-08-01 13:28, Stefan Wahren wrote:
quoted hunk ↗ jump to hunk
Fix the node name to get the rid of the following DT schema warning:
'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)
(@[0-9a-f]+)?$'

Signed-off-by: Stefan Wahren <redacted>
---
 arch/arm/boot/dts/bcm2711.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm2711.dtsi 
b/arch/arm/boot/dts/bcm2711.dtsi
index b8a4096..afe0ef8 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -405,7 +405,7 @@
 	 * The firmware will find whether the emmc2bus alias is defined, and 
if
 	 * so, it'll edit the dma-ranges property below accordingly.
 	 */
-	emmc2bus: emmc2bus {
+	emmc2bus: emmc2-bus {
There was a recent breakage on rk3399 because of a similar change.

This is a userspace visible change (it affects the sysfs paths),
which will break people's scripts. It would be a lot better to
add an annotation to the DT to acknowledge the issue and keep
the checker quiet.

         M.
-- 
Jazz is not dead. It just smells funny...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help