Thread (6 messages) 6 messages, 3 authors, 2021-09-01

Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c

flat view

From: Andy Shevchenko <hidden>
Date: 2021-08-30 10:57:02
Also in: alsa-devel, lkml

On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla [off-list ref] wrote:
Drive the reset gpio if defined in the DTS node.
...
+       reset_gpio
+               = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);
A bit of a strange indentation, shouldn't it be one line?
+       if (IS_ERR(reset_gpio)) {
quoted hunk ↗ jump to hunk
+               ret = PTR_ERR(reset_gpio);
+               return dev_err_probe(&i2c->dev, ret,
+                       "failed to request GPIO reset pin");
It simply as

               return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
                       "failed to request GPIO reset pin");
+       }
-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help