Re: [PATCH 3/9] media: mtk-vcodec: Rewrite venc power manage interface
From: Tzung-Bi Shih <hidden>
Date: 2021-08-23 10:16:55
Also in:
linux-arm-kernel, linux-media, linux-mediatek, lkml
On Mon, Aug 16, 2021 at 06:59:28PM +0800, Irui Wang wrote:
quoted hunk ↗ jump to hunk
@@ -105,6 +106,14 @@ static int mtk_venc_comp_probe(struct platform_device *pdev) comp_dev->plat_dev = pdev; + ret = mtk_vcodec_init_enc_pm(pdev, &comp_dev->pm); + if (ret < 0) { + dev_err(&pdev->dev, "Failed to get venc component clock source!"); + return ret; + } + + pm_runtime_enable(&pdev->dev);
mtk_vcodec_init_enc_pm() and mtk_vcodec_release_enc_pm() is more like a pair. Does it make more sense to call pm_runtime_enable() in mtk_vcodec_init_enc_pm()?