Hi Ezequiel,

Thanks for your suggestion.

On Wed, 2021-08-18 at 11:11 -0300, Ezequiel Garcia wrote:

+danvet

Hi,

On Tue, 10 Aug 2021 at 23:58, Yunfei Dong [off-list ref]
wrote:

quoted

This series adds support for multi hardware decode into mtk-vcodec, 
by first
adding component framework to manage each hardware information:
interrupt,
clock, register bases and power. Secondly add core thread to deal
with core
hardware message, at the same time, add msg queue for different
hardware
share messages. Lastly, the architecture of different specs are not
the same,
using specs type to separate them.

I don't think it's a good idea to introduce the component API in the
media subsystem. It doesn't seem to be maintained, IRC there's not
even
a maintainer for it, and it has some issues that were never
addressed.

It would be really important to avoid it. Is it really needed in the
first place?

Thanks,
Ezequiel

For there are many hardware need to use, mt8192 is three and mt8195 is
five. Maybe need more to be used in the feature.

Each hardware has independent clk/power/iommu port/irq.
Use component interface in prob to get each component's information.
Just enable the hardware when need to use it, very convenient and
simple.

I found that there are many modules use component to manage hardware
information, such as iommu and drm etc.

Do you have any other suggestion for this architecture?

Thanks
Yunfei Dong