Re: [PATCH v9 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string
From: Maxime Ripard <hidden>
Date: 2021-08-18 08:15:34
Also in:
linux-arm-kernel, linux-rtc, linux-sunxi, lkml
On Mon, Aug 02, 2021 at 01:39:43AM +0100, Andre Przywara wrote:
quoted hunk ↗ jump to hunk
Add the obvious compatible name to the existing RTC binding. The actual RTC part of the device uses a different day/month/year storage scheme, so it's not compatible with the previous devices. Also the clock part is quite different, as there is no external 32K LOSC oscillator input. Signed-off-by: Andre Przywara <andre.przywara@arm.com> Reviewed-by: Rob Herring <robh@kernel.org> --- .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml index beeb90e55727..d8a6500e5840 100644 --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml@@ -26,6 +26,7 @@ properties: - const: allwinner,sun50i-a64-rtc - const: allwinner,sun8i-h3-rtc - const: allwinner,sun50i-h6-rtc + - const: allwinner,sun50i-h616-rtc reg: maxItems: 1@@ -104,6 +105,19 @@ allOf: minItems: 3 maxItems: 3 + - if: + properties: + compatible: + contains: + const: allwinner,sun50i-h616-rtc + + then: + properties: + clock-output-names: + minItems: 3 + maxItems: 3
The comments I made here on the v7 are still relevant: you only need one of these two, and the list of clocks should be documented. Maxime
Attachments
- signature.asc [application/pgp-signature] 228 bytes