Thread (8 messages) 8 messages, 3 authors, 2021-09-07

RE: [EXT] Re: [PATCH 2/2] dt-bindings: perf: Add YAML schemas for Marvell CN10K LLC-TAD pmu bindings

From: Bhaskara Budiredla <hidden>
Date: 2021-08-17 09:11:55
Also in: linux-arm-kernel, lkml

Hi Rob,

Thanks for the steps. I seeing minimum version error, though the dtschema is latest.

$ make dt_binding_check
sort: -:2: disorder: 0
ERROR: dtschema minimum version is v2021.2.1
Documentation/devicetree/bindings/Makefile:12: recipe for target 'check_dtschema_version' failed
make[1]: *** [check_dtschema_version] Error 1
Makefile:1418: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

$ pip3 show dtschema
Name: dtschema
Version: 2021.7
Summary: DeviceTree validation schema and tools
Home-page: https://github.com/devicetree-org/dt-schema
Author: Rob Herring
Author-email: robh@kernel.org
License: BSD

Thanks,
Bhaskara
-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Friday, August 13, 2021 5:41 PM
To: Bhaskara Budiredla <redacted>
Cc: will@kernel.org; linux-arm-kernel@lists.infradead.org;
mark.rutland@arm.com; Sunil Kovvuri Goutham [off-list ref];
devicetree@vger.kernel.org; robh+dt@kernel.org; linux-
kernel@vger.kernel.org
Subject: [EXT] Re: [PATCH 2/2] dt-bindings: perf: Add YAML schemas for
Marvell CN10K LLC-TAD pmu bindings

External Email

----------------------------------------------------------------------
On Thu, 12 Aug 2021 23:12:09 +0530, Bhaskara Budiredla wrote:
quoted
Add device tree bindings for Last-level-cache Tag-and-data
(LLC-TAD) unit PMU for Marvell CN10K SoCs.

Signed-off-by: Bhaskara Budiredla <redacted>
---
 .../bindings/perf/marvell-cn10k-tad.yaml      | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/perf/marvell-cn10k-tad.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/perf/marvell-cn10k-
tad.example.dts:19.32-25.11: Warning (unit_address_format): /example-
0/tad_pmu@0x87e280000000: unit name should not have leading "0x"
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/perf/marvell-cn10k-
tad.example.dt.yaml: example-0: tad_pmu@0x87e280000000:reg:0: [34786,
2147483648, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-
packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/perf/marvell-cn10k-
tad.example.dt.yaml: example-0: 'tad_pmu@0x87e280000000' does not
match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-
9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-
._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', 'pinctrl-[0-9]+'
From schema: /usr/local/lib/python3.8/dist-
packages/dtschema/schemas/dt-core.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/perf/marvell-cn10k-
tad.example.dt.yaml: tad_pmu@0x87e280000000: 'tad-cnt', 'tad-page-size',
'tad-pmu-page-size' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/perf/marvell-cn10k-tad.yaml

doc reference errors (make refcheckdocs):

See https://urldefense.proofpoint.com/v2/url?u=https-
3A__patchwork.ozlabs.org_patch_1516395&d=DwIBAg&c=nKjWec2b6R0mOy
Paz7xtfQ&r=9P_lSljSO7KnQNkCGsgu9x_Op4mstSdqWN3Olr4bUv0&m=Kqfvr5E
wn5St-
WmEqTDaMI6uM6H5x0uiuOxZTYd15Gc&s=NYt8Ae1pxJhBgLN5asKagq1BUQi_
gqK_RBkBSmcCvAU&e=

This check can fail if there are any dependencies. The base for a patch series is
generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s),
then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help