Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
From: Rob Herring <robh@kernel.org>
Date: 2021-08-11 17:37:47
Also in:
linux-arm-msm, lkml
On Tue, Aug 10, 2021 at 11:31:22PM +0530, Rakesh Pillai wrote:
quoted hunk ↗ jump to hunk
Add WPSS PIL loading support for SC7280 SoCs. Signed-off-by: Rakesh Pillai <redacted> --- .../bindings/remoteproc/qcom,hexagon-v56.yaml | 79 ++++++++++++++++++++-- 1 file changed, 74 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.yaml index 5f3558e..9ae433c6 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.yaml@@ -17,6 +17,7 @@ properties: compatible: enum: - qcom,qcs404-cdsp-pil + - qcom,sc7280-wpss-pil - qcom,sdm845-adsp-pil reg:@@ -26,25 +27,30 @@ properties: interrupts-extended: minItems: 5 - maxItems: 5 + maxItems: 6 interrupt-names: minItems: 5 - maxItems: 5 + maxItems: 6 clocks: - minItems: 7 + minItems: 3
Patch 1 shows 3 clocks are valid...
quoted hunk ↗ jump to hunk
maxItems: 8 description: List of phandles and clock specifier pairs for the Hexagon, per clock-names below. clock-names: - minItems: 7 + minItems: 3 maxItems: 8 power-domains: - maxItems: 1 + minItems: 1 + maxItems: 2 + + power-domain-names: + minItems: 1 + maxItems: 2 resets: minItems: 1@@ -92,6 +98,7 @@ required: - clocks - clock-names - power-domains + - power-domain-names
It's not backwards compatible to add a required property.
quoted hunk ↗ jump to hunk
- qcom,halt-regs - memory-region - qcom,smem-states@@ -129,6 +136,31 @@ allOf: compatible: contains: enum: + - qcom,sc7280-wpss-pil + then: + properties: + interrupts-extended: + items: + - description: Watchdog interrupt + - description: Fatal interrupt + - description: Ready interrupt + - description: Handover interrupt + - description: Stop acknowledge interrupt + - description: Shutdown acknowledge interrupt + interrupt-names: + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + - const: shutdown-ack
The items lists can go in the main section with 'minItems: 5' and just 'minItems: 6' here.
quoted hunk ↗ jump to hunk
+ + - if: + properties: + compatible: + contains: + enum: - qcom,sdm845-adsp-pil then: properties:@@ -211,6 +243,26 @@ allOf: power-domains: items: - description: CX power domain + power-domain-names: + items: + - const: cx + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-wpss-pil + then: + properties: + power-domains: + items: + - description: CX power domain + - description: MX power domain + power-domain-names: + items: + - const: cx + - const: mx
As 'cx' is always the first entry, the 'items' lists here can be moved to the main section and you just need minItems or maxItems in the if/then.
quoted hunk ↗ jump to hunk
- if: properties:@@ -244,6 +296,23 @@ allOf: items: - const: restart + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-wpss-pil + then: + properties: + resets: + items: + - description: AOSS restart + - description: PDC SYNC + reset-names: + items: + - const: restart + - const: pdc_sync + examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h>-- 2.7.4