RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property

-----Original Message-----
From: Joakim Zhang <redacted>
Sent: 2021年8月11日 16:05
To: Jan Lübbe <jlu@pengutronix.de>; srinivas.kandagatla@linaro.org;
robh+dt@kernel.org; shawnguo@kernel.org
Cc: devicetree@vger.kernel.org; dl-linux-imx <redacted>;
kernel@pengutronix.de; linux-kernel@vger.kernel.org
Subject: RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
property

quoted

-----Original Message-----
From: Jan Lübbe <jlu@pengutronix.de>
Sent: 2021年8月10日 23:14
To: Joakim Zhang <redacted>;
srinivas.kandagatla@linaro.org; robh+dt@kernel.org;
shawnguo@kernel.org
Cc: devicetree@vger.kernel.org; dl-linux-imx <redacted>;
kernel@pengutronix.de; linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
property

On Tue, 2021-08-10 at 15:35 +0800, Joakim Zhang wrote:

quoted

Introduce "reverse-data" property for nvmem provider to reverse buffer.

Signed-off-by: Joakim Zhang <redacted>
---
 Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml

b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
index b8dc3d2b6e92..bc745083fc64 100644

--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml

@@ -61,6 +61,11 @@ patternProperties:
               description:
                 Size in bit within the address range specified by reg.

+      reverse-data:
+        $ref: /schemas/types.yaml#/definitions/flag
+        description:
+          Reverse the data that read from the storage device.

I'd prefer if it was more explicit that the *bytes* will be reversed.
Otherwise a reader might think that this is reversing on the *bit* level.

Make sense, how about 'reverse-byte-order'?

Sorry, 'reverse-bytes-order'.

Best Regards,
Joakim Zhang

Best Regards,
Joakim Zhang

quoted

Jan

quoted

+
     required:
       - reg

--
Pengutronix e.K.                           |
|
Steuerwalder Str. 21                       |
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
e

ngutronix.de%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7C79

quoted

3a60188540455919b608d95c118878%7C686ea1d3bc2b4c6fa92cd99c5c30163

quoted

5%7C0%7C0%7C637642052637994749%7CUnknown%7CTWFpbGZsb3d8eyJWI

quoted

joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1

quoted

000&sdata=S27O8AV8lRvGxyEutJl6Uh4AjbArD%2BkvQl%2FI05ZU1P8%3D

quoted

&reserved=0  |
31137 Hildesheim, Germany                  | Phone:

+49-5121-206917-0

quoted

|
Amtsgericht Hildesheim, HRA 2686           | Fax:
+49-5121-206917-5555 |