Re: [PATCH v10 02/11] mfd: simple-mfd-i2c: Add a Kconfig name
From: Lee Jones <hidden>
Date: 2021-08-10 07:53:31
Also in:
lkml
On Sat, 07 Aug 2021, Alistair Francis wrote: You need a better commit message. What are you doing? Why are you doing it? What happens if you don't do it?
Signed-off-by: Alistair Francis <redacted> --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I guess there's no harm in it. That does mean you'll need a bespoke defconfig to run your build, which is not advisable for generic maintenance and testing purposes. What architecture does your H/W operate on?
quoted hunk ↗ jump to hunk
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6a3fd2d75f96..09a939f8b7ff 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig@@ -1176,7 +1176,7 @@ config MFD_SI476X_CORE module will be called si476x-core. config MFD_SIMPLE_MFD_I2C - tristate + tristate "Simple MFD device"
That's not right. You're saying: "Simple Multi-Functional Device device" It should be something more like: "Simple Multi-Functional Device support (I2C)"
depends on I2C select REGMAP_I2C help
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog