Re: [PATCH 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel
flat view
From: Linus Walleij <hidden>
Date: 2021-08-05 21:06:48
Also in:
dri-devel, lkml, phone-devel
Hi Markuss, sorry for reacting so late! On Thu, Aug 5, 2021 at 3:36 PM Markuss Broks [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+#define s6d27a1_command(ctx, cmd, seq...) \ +({ \ + struct mipi_dbi *dbi = &ctx->dbi; \ + int ret; \ + ret = mipi_dbi_command(dbi, cmd, seq); \ + if (ret) { \ + dev_err(ctx->dev, "failure in writing command %02x\n", cmd); \ + } \ +})
You don't need this wrapper anymore, just call mipi_dbi_command() directly everywhere you use s6d27a1_command(). Because I merged this patch: https://cgit.freedesktop.org/drm/drm-misc/commit/include/drm/drm_mipi_dbi.h?id=3f5aa5ac0b0f9704f0c60f5fbbbcdc8c043d6eb6 Yours, Linus Walleij