Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support
From: H. Nikolaus Schaller <hidden>
Date: 2021-08-05 14:46:19
Also in:
dri-devel, linux-mips, lkml
From: H. Nikolaus Schaller <hidden>
Date: 2021-08-05 14:46:19
Also in:
dri-devel, linux-mips, lkml
Hi Robert,
Am 05.08.2021 um 16:32 schrieb Robert Foss [off-list ref]: Hey Nikolaus, Thanks for submitting this series. On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller [off-list ref] wrote:quoted
From: Paul Boddie <redacted> + .mode_fixup = dw_hdmi_bridge_mode_fixup,mode_fixup() has been deprecated[1] in favor of atomic_check(), care has to be taken when switching to atomic_check() as it has access to the full atomic commit. Looking at this driver, it's using mode_set as well, which should be fixed. [1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ (local)
Thanks for this link! I have found some patches which convert mode_fixup -> atomic_check (e.g. 3afb2a28fa2404) and atomic_check was apparently introduced by b86d895524ab72 That should be sufficient information that we can modify it. BR and thanks, Nikolaus