Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries
flat view
From: Li Yang <hidden>
Date: 2021-08-02 22:44:45
Also in:
linux-arm-kernel, lkml
On Mon, Aug 2, 2021 at 1:10 PM Raag Jadav [off-list ref] wrote:
ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] eeproms respectively. Both are 4Kb (512 bytes) in size.
These part names are from onsemi instead of atmel. Are there same part names from atmel which are also compatible with the onsemi parts? If we want to use onsemi only part names, probably we will need two compatible strings with the first one from onsemi and the second from atmel. Although the binding doesn't support onsemi prefix yet.
Remove multi-address entries, as we have auto-rollover support in at24 driver.
The device tree should describe hardware instead of matching how driver deal with it. Is the board really using a single chip or multiple chips here?
quoted hunk ↗ jump to hunk
[1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf Signed-off-by: Raag Jadav <redacted> --- arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +------- arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 7 +------ 2 files changed, 2 insertions(+), 13 deletions(-)diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts index db3d303..83afe21 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts@@ -83,15 +83,9 @@ }; eeprom@52 { - compatible = "atmel,24c512"; + compatible = "atmel,24c04"; reg = <0x52>; }; - - eeprom@53 { - compatible = "atmel,24c512"; - reg = <0x53>; - }; - }; }; };diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts index 60acdf0..d220f98 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts@@ -59,14 +59,9 @@ }; eeprom@52 { - compatible = "atmel,24c512"; + compatible = "atmel,24c04"; reg = <0x52>; }; - - eeprom@53 { - compatible = "atmel,24c512"; - reg = <0x53>; - }; }; &i2c3 { --2.7.4